Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix depend element for eigen #76

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Fix depend element for eigen #76

merged 1 commit into from
Nov 1, 2018

Conversation

ruffsl
Copy link
Member

@ruffsl ruffsl commented Oct 31, 2018

No description provided.

@ruffsl ruffsl added the in progress Actively being worked on (Kanban column) label Oct 31, 2018
@ruffsl ruffsl mentioned this pull request Oct 31, 2018
Merged
@ruffsl ruffsl added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Oct 31, 2018
@SteveMacenski
Copy link
Contributor

Thanks for fixing this

@ruffsl ruffsl merged commit db72716 into ros2 Nov 1, 2018
@ruffsl ruffsl removed the in review Waiting for review (Kanban column) label Nov 1, 2018
@dirk-thomas
Copy link
Member

@ruffsl do you still need the branch or can it be deleted?

@ruffsl ruffsl deleted the depend_eigen branch November 1, 2018 18:28
@ruffsl
Copy link
Member Author

ruffsl commented Nov 1, 2018

pardon me, branched deleted.

@wjwwood
Copy link
Member

wjwwood commented Nov 1, 2018 •
edited
Loading

I'm getting this new failure for tf2_sensor_msgs on my CI:

18:39:33 CMake Error at /home/rosbuild/ci_scripts/ws/install/ament_cmake_auto/share/ament_cmake_auto/cmake/ament_auto_find_build_dependencies.cmake:56 (message):
18:39:33   ament_auto_find_build_dependencies() called with required packages that are
18:39:33   not listed as a build/buildtool dependency in the package.xml: Eigen3
18:39:33 Call Stack (most recent call first):
18:39:33   CMakeLists.txt:21 (ament_auto_find_build_dependencies)
18:39:33 
18:39:33 
18:39:33 ---

-- from: https://ci.ros2.org/job/ci_linux-aarch64/2141/consoleFull#console-section-370

🤣

@wjwwood wjwwood mentioned this pull request Nov 1, 2018
Merged
@mjcarroll
Copy link
Member

#77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@tfoote tfoote tfoote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ruffsl @SteveMacenski @dirk-thomas @wjwwood @mjcarroll @tfoote