-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete TRANSITION_SHUTDOWN #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to renumber the constants?
@dirk-thomas Any recommendations for it? Do have specific numbering in mind? |
lifecycle_msgs/msg/Transition.msg
Outdated
uint8 TRANSITION_SHUTDOWN = 5 | ||
uint8 TRANSITION_UNCONFIGURED_SHUTDOWN = 50 | ||
uint8 TRANSITION_INACTIVE_SHUTDOWN = 51 | ||
uint8 TRANSITION_ACTIVE_SHUTDOWN = 52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe 5
- 7
for the new transitions and bumping TRANSITION_DESTROY
to 8
?
@@ -34,9 +36,6 @@ uint8 TRANSITION_ON_DEACTIVATE_SUCCESS = 40 | |||
uint8 TRANSITION_ON_DEACTIVATE_FAILURE = 41 | |||
uint8 TRANSITION_ON_DEACTIVATE_ERROR = 42 | |||
|
|||
uint8 TRANSITION_UNCONFIGURED_SHUTDOWN = 50 | |||
uint8 TRANSITION_INACTIVE_SHUTDOWN = 51 | |||
uint8 TRANSITION_ACTIVE_SHUTDOWN = 52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe 50
- 52
for the remaining on-shutdown transitions?
@dirk-thomas does that look correct to you? |
fixes ros2/rcl#309