Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid launch dependency on lark #282

Open
ivanpauno opened this issue Jul 24, 2019 · 1 comment
Open

Avoid launch dependency on lark #282

ivanpauno opened this issue Jul 24, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ivanpauno
Copy link
Member

Feature request

Feature description

#226 added a dependency on lark to launch:

<depend>osrf_pycommon</depend>
<exec_depend>ament_index_python</exec_depend>
<exec_depend>python3-lark-parser</exec_depend>
.
It can be easily avoided moving the substitution parser to an independent package.

Implementation considerations

launch_xml, launch_yaml can then import this package and override the Parser parse_substitution method.

@ivanpauno ivanpauno added this to To do in Eloquent via automation Jul 24, 2019
@ivanpauno
Copy link
Member Author

@wjwwood @hidmic FYI

@wjwwood wjwwood added enhancement New feature or request help wanted Extra attention is needed labels Jul 25, 2019
@mjcarroll mjcarroll moved this from To do to In progress in Eloquent Feb 5, 2020
@clalancette clalancette removed this from In progress in Eloquent May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants