Improve launch file parsing error messages #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonegk
force-pushed
the
improve_error_messages
branch
from
347cd07
to
07da9df
Compare
audrow
approved these changes
Jul 26, 2022
launch_xml/launch_xml/entity.py
Outdated
| @@ -91,7 +91,7 @@ def get_attr( | |||
| If coercion fails, `ValueError` will be raised. | |||
| """ | |||
| attr_error = AttributeError( | |||
| 'Attribute {} of type {} not found in Entity {}'.format( | |||
| 'Attribute `{}` of type `{}` not found in Entity `{}`'.format( | |||
There was a problem hiding this comment.
Suggested change
| 'Attribute `{}` of type `{}` not found in Entity `{}`'.format( | |
| "Attribute '{}' of type '{}' not found in Entity '{}'".format( |
I would prefer using single quotes (') instead of ticks, like here:
launch/launch/launch/event_handler.py
Line 83 in cb39d92
The same goes for the other locations.
There was a problem hiding this comment.
No problem, I also prefer them. I just did it like the other error messages in the same file.
There was a problem hiding this comment.
Oh, you're right. I believe when I made the comment I looked elsewhere in the repository and saw the single quotes in use. It'd be nice to have this more consistent within and across files.
|
@ros-pull-request-builder retest this please |
|
|
@audrow friendly ping |
|
@audrow ping |
clalancette
requested changes
Jul 4, 2023
timonegk
force-pushed
the
improve_error_messages
branch
from
d4869dc
to
595ff68
Compare
timonegk
requested review from
adityapande-1995,
methylDragon and
wjwwood
as code owners
clalancette
approved these changes
Jul 4, 2023
|
CI:
|
Signed-off-by: Timon Engelke <timon.engelke@online.de>
Signed-off-by: Timon Engelke <timon.engelke@online.de>
Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Timon Engelke <timon.engelke@online.de>
clalancette
force-pushed
the
improve_error_messages
branch
from
595ff68
to
2af2fb4
Compare
|
I rebased this onto the latest. Here is another CI run:
|
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
CI again after flake8 fix:
|
wjwwood
pushed a commit
that referenced
this pull request
Sep 20, 2023
* Improve launch file parsing error messages Signed-off-by: Timon Engelke <timon.engelke@online.de> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
dyackzan
added a commit
to dyackzan/launch
that referenced
this pull request
Jan 25, 2024
Backport of ros2#626: * Parser errors clearly show that values are substituted and not part of the error message itself. * On an InvalidLaunchFileError, all parsing errors are logged. Signed-off-by: David Yackzan <dwyackzan@gmail.com>
clalancette
pushed a commit
that referenced
this pull request
Feb 3, 2024
* Improve launch file parsing error messages Backport of #626: * Parser errors clearly show that values are substituted and not part of the error message itself. * On an InvalidLaunchFileError, all parsing errors are logged. * Add exception type to error output Backport of #753: * Output exception type for InvalidLaunchFileErrors * Add test checking for exception type in output Signed-off-by: David Yackzan <dwyackzan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the parsing error messages for launch files in two ways:
Attribute value of type <class 'str'> not found in Entity let, not realizing that the attribute "value" was missing and not some kind of "attribute value".