Backport error message improvements #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of ros2#626: * Parser errors clearly show that values are substituted and not part of the error message itself. * On an InvalidLaunchFileError, all parsing errors are logged. Signed-off-by: David Yackzan <dwyackzan@gmail.com>
Backport of ros2#753: * Output exception type for InvalidLaunchFileErrors * Add test checking for exception type in output Signed-off-by: David Yackzan <dwyackzan@gmail.com>
|
@tylerjw @clalancette here's the backport as discussed in #753 (comment) |
tylerjw
approved these changes
Feb 1, 2024
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #626 and #753