Add in a timeout for launch pytests. #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently had a PR where the tests for launch hung, and this hung the CI job forever. Avoid this by adding in a 900 second timeout for the launch tests. Given that our current launch tests take ~200 seconds on our slowest platform, this should be plenty of overhead to ensure we have no "flakes". Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested review from
adityapande-1995,
methylDragon and
wjwwood
as code owners
mjcarroll
approved these changes
Aug 23, 2023
|
CI:
|
wjwwood
pushed a commit
that referenced
this pull request
Sep 20, 2023
We recently had a PR where the tests for launch hung, and this hung the CI job forever. Avoid this by adding in a 900 second timeout for the launch tests. Given that our current launch tests take ~200 seconds on our slowest platform, this should be plenty of overhead to ensure we have no "flakes". Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had a PR where the tests for launch hung, and this hung the CI job forever. Avoid this by adding in a 900 second timeout for the launch tests. Given that our current launch tests take ~200 seconds on our slowest platform, this should be plenty of overhead to ensure we have no "flakes".