Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing annotations of variables used in launch only available for python 3.6+ #78

Closed
dhood opened this issue Jun 14, 2018 · 1 comment · Fixed by #81
Closed

Typing annotations of variables used in launch only available for python 3.6+ #78

dhood opened this issue Jun 14, 2018 · 1 comment · Fixed by #81
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dhood
Copy link
Member

dhood commented Jun 14, 2018

http://mypy.readthedocs.io/en/latest/cheat_sheet_py3.html#variables

causes failures on xenial jobs, e.g.:

    from .launch_context import LaunchContext
E     File "/home/rosbuild/ci_scripts/ws/install/launch/lib/python3.5/site-packages/launch/launch_context.py", line 45
E       self._event_queue: asyncio.Queue = asyncio.Queue()
E                        ^
E   SyntaxError: invalid syntax
@dhood dhood added the bug Something isn't working label Jun 14, 2018
@dhood dhood added this to the bouncy milestone Jun 14, 2018
@dhood
Copy link
Member Author

dhood commented Jun 14, 2018

@wjwwood putting this here for tracking/visibility, not trying to dump it and leave it. we can group-schedule it when it reaches priority.

@dhood dhood changed the title Typing annotations used in launch only available for python 3.6+ Typing annotations of variables used in launch only available for python 3.6+ Jun 15, 2018
@dhood dhood added the ready Work is about to start (Kanban column) label Jun 15, 2018
@wjwwood wjwwood self-assigned this Jun 16, 2018
@dhood dhood assigned dhood and unassigned wjwwood Jun 16, 2018
@dhood dhood added in progress Actively being worked on (Kanban column) and removed ready Work is about to start (Kanban column) labels Jun 16, 2018
@dhood dhood added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jun 18, 2018
@dhood dhood closed this as completed in #81 Jun 18, 2018
@dhood dhood removed the in review Waiting for review (Kanban column) label Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants