update bouncy branch #125
Merged
update bouncy branch #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #115 Signed-off-by: William Woodall <william@osrfoundation.org>
* add Condition class and use in Action class * add If and Unless Conditions which use Substitutions * update actions to pass through condition arguments to Action base class * fixup type annotations in ExecuteProcess action * fixup architecture doc * address flake8 failure that doesn't show locally for me
* improve handling of exceptions and fix improperly placed nonlocal Signed-off-by: William Woodall <william@osrfoundation.org> * change LaunchDescriptionSource to get a context for expanding subs Signed-off-by: William Woodall <william@osrfoundation.org> * create new launch description source for Python launch files Signed-off-by: William Woodall <william@osrfoundation.org> To do this, moved functions for loading Python launch files into launch. Signed-off-by: William Woodall <william@osrfoundation.org> * add new substitution to get the directory of the current launch file Signed-off-by: William Woodall <william@osrfoundation.org> * example of including another launch file Signed-off-by: William Woodall <william@osrfoundation.org> * rename file for ThisLaunchFileDir substitution Signed-off-by: William Woodall <william@osrfoundation.org> * typo Signed-off-by: William Woodall <william@osrfoundation.org> * only do abspath and dirname if launch file location exists Signed-off-by: William Woodall <william@osrfoundation.org> * add tests Signed-off-by: William Woodall <william@osrfoundation.org> * remove unused import Signed-off-by: William Woodall <william@osrfoundation.org>
wjwwood
added
in review
12 tasks
|
no worries 👍 thanks for taking care of releasing it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikaelarguedas sorry for forgetting to do this before.