Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LaunchLogger class #145

Merged
merged 18 commits into from
Mar 14, 2019
Merged

Add LaunchLogger class #145

merged 18 commits into from
Mar 14, 2019

Commits on Mar 12, 2019

  1. Add LaunchLogger class 

    Supports logging messages from multiple processes and modules to the screen, a common log file, or both.
LaunchLogger is a singleton and when it is first instantiated a log file is created of the form 'DATETIME-launch-HOSTNAME-PID.log'.
Messages sent to the screen or the log file will have the format 'TIME [LEVEL] NAME: MESSAGE'.
    @jacobperron @hidmic
    jacobperron authored and hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    aa1127a View commit details
    Browse the repository at this point in the history

  2. Add different formats for log and screen in launch logger 

    The timestamp in the screen format is optional.
    @jacobperron @hidmic
    jacobperron authored and hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    9e3d741 View commit details
    Browse the repository at this point in the history

  3. Use LoggerLevel.INFO instead of logging.INFO

    @jacobperron @hidmic
    jacobperron authored and hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    5ecad19 View commit details
    Browse the repository at this point in the history

  4. Fixup 'screen' logging logic 

    Also extends LaunchLogger interface.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    bf8cc04 View commit details
    Browse the repository at this point in the history

  5. Refactors launch logging. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    7ccc29b View commit details
    Browse the repository at this point in the history

  6. Preconfigures launch.logging loggers. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    4dc0bdf View commit details
    Browse the repository at this point in the history

  7. Addresses peer review comments. 

    - Fix style and documentation issues.
- Removes dangling TODO.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    fa09a31 View commit details
    Browse the repository at this point in the history

  8. style and documentation fixups 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood @hidmic
    wjwwood authored and hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    adb401d View commit details
    Browse the repository at this point in the history

  9. fix name shadowing (mypy complained) 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood @hidmic
    wjwwood authored and hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    fe67a70 View commit details
    Browse the repository at this point in the history

  10. Replace capfd with capsys in launch.logging tests. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    0d3b9ed View commit details
    Browse the repository at this point in the history

  11. Integrate LaunchLogger in launch 

    Replacing usage of the Python logging module with the new LaunchLogger.
    @jacobperron @hidmic
    jacobperron authored and hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    b6f8d16 View commit details
    Browse the repository at this point in the history

  12. Integrate LaunchLogger in launch_ros 

    Also, removed unecessary logging logic.
    @jacobperron @hidmic
    jacobperron authored and hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    5c2f144 View commit details
    Browse the repository at this point in the history

  13. Clean up LaunchLogger integration with launch 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    ae62f5d View commit details
    Browse the repository at this point in the history

  14. Refactor launch logging integration. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    ea0b439 View commit details
    Browse the repository at this point in the history

  15. Switch to non-relative launch.logging imports. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    c6a1817 View commit details
    Browse the repository at this point in the history

  16. Turn ExecuteProcess output_prefix into an output_format. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    44d14d2 View commit details
    Browse the repository at this point in the history

  17. Convert launch logging API names to snake case. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    27fc2c3 View commit details
    Browse the repository at this point in the history

  18. Minor fixes after rebase. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    9872792 View commit details
    Browse the repository at this point in the history