Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing method for DeclareLaunchArgument #270

Merged
merged 2 commits into from
Jul 12, 2019

Conversation

ivanpauno
Copy link
Member

Just what the title says.

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added enhancement New feature or request in review Waiting for review (Kanban column) labels Jul 11, 2019
@ivanpauno ivanpauno requested a review from hidmic July 11, 2019 21:13
@ivanpauno ivanpauno self-assigned this Jul 11, 2019
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

@ivanpauno
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit d5c5f54 into master Jul 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/declare-launch-argument-parsing-method branch July 12, 2019 18:46
@ivanpauno ivanpauno restored the ivanpauno/declare-launch-argument-parsing-method branch July 26, 2019 19:17
@ivanpauno ivanpauno deleted the ivanpauno/declare-launch-argument-parsing-method branch July 26, 2019 19:25
piraka9011 pushed a commit to aws-ros-dev/launch that referenced this pull request Aug 16, 2019
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants