Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "hello world" style example #532

Merged
merged 7 commits into from
Sep 15, 2021
Merged

Add a "hello world" style example #532

merged 7 commits into from
Sep 15, 2021

Conversation

adityapande-1995
Copy link
Contributor

This PR aims to add a "hello world" style basic example meant to show the general structure of launch tests.

Signed-off-by: Aditya Pande aditya050995@gmail.com

@adityapande-1995
Added hello_world example and updated README
67dcf68 
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
This was referenced Sep 13, 2021
Closed
Merged
@adityapande-1995
Added marker
118d001 
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
@adityapande-1995
Updated readme, docstrings
23778e9 
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
jacobperron
jacobperron reviewed Sep 13, 2021
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a nice minimal example. Are you planning to create a more detailed guide on ros2/ros2_documentation to go along with this? If not, I think we could provide more explanation with more comments in the code and maybe in the README.

launch_testing/README.md Outdated Show resolved Hide resolved
launch_testing/test/launch_testing/examples/hello_world_launch_test.py Outdated Show resolved Hide resolved
@adityapande-1995
Updated readme, added comments to .py file
9702f28 
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
@adityapande-1995
Copy link
Contributor Author

I'm planning to add a page to ros2_documentation explaining the examples, but adding comments is a good idea actually.

@adityapande-1995
Updated comment in .py file
fe3c296 
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
ivanpauno
ivanpauno approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example LGTM!

@adityapande-1995
Copy link
Contributor Author

CI :

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@adityapande-1995
Added shell='True' for windows CI
d5f9daa 
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
@adityapande-1995
typo fix
b6abc21 
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
@adityapande-1995
Copy link
Contributor Author

CI :

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@adityapande-1995 adityapande-1995 merged commit 026ab0e into master Sep 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the aditya/hello_world_example branch September 15, 2021 18:00
@adityapande-1995 adityapande-1995 mentioned this pull request Sep 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adityapande-1995 @jacobperron @ivanpauno