-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Fixes #87
Windows Fixes #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this commit I'm not too sure on: e14e644 but otherwise it looks good. Tested on xenial and works as expected.
There's a traceback in the CI testing output: https://ci.ros2.org/job/ci_linux/4774/console#console-section-12
|
Oh good catch, I'll look into that. |
It only happens when you use the "repeat until fail" logic, which translates to |
For future readers, it was caused by a race condition (wasn't specific to pytest) |
Fixes #86
The first commit (there will be more) should cause the tests to fail, where they were silently ignoring exceptions that made it fail on Windows.