Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LoadComposableNodes action so that loading happens asynchronously #113

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Fix LoadComposableNodes action so that loading happens asynchronously #113

merged 2 commits into from
Jan 30, 2020

Conversation

jacobperron
Copy link
Member

Fixes #107.

I'm not sure if this is the best solution, but it gets the job done.

@jacobperron
Call load node service in a separate thread
d50ee96 
Fixes #107.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Make the first call to _load_in_sequence asynchronously
04ce971 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
wjwwood
wjwwood approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it's that the first call to _load_in_sequence is not asynchronous, but subsequent calls are (it is recursive).

lgtm

@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron changed the title Call load node service in a separate thread Fix LoadComposableNodes action so that loading happens asynchronously Jan 30, 2020
@jacobperron jacobperron merged commit 4f03b24 into master Jan 30, 2020
@jacobperron jacobperron deleted the jacob/fix_107 branch January 30, 2020 23:24
@jacobperron jacobperron added this to Needs Backport in Eloquent Patch Release 2 Jan 30, 2020
@jacobperron jacobperron added this to Needs Backport in Dashing Patch Release 6 Jan 30, 2020
jacobperron added a commit that referenced this pull request Mar 12, 2020
@jacobperron
Fix LoadComposableNodes action so that loading happens asynchronously (…
e5081b5 
…#113)

Fixes #107.

Before, the first call to _load_in_sequence was not asynchronous, unlike it's recursive calls.
This change makes the first call asynchronous.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request Mar 12, 2020
@jacobperron
Fix LoadComposableNodes action so that loading happens asynchronously (…
a29fc49 
…#113)

Fixes #107.

Before, the first call to _load_in_sequence was not asynchronous, unlike it's recursive calls.
This change makes the first call asynchronous.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request Mar 12, 2020
Merged
@jacobperron jacobperron removed this from Needs Backport in Dashing Patch Release 6 Mar 12, 2020
@jacobperron jacobperron mentioned this pull request Mar 12, 2020
Merged
@jacobperron jacobperron removed this from Needs Backport in Eloquent Patch Release 2 Mar 12, 2020
jacobperron added a commit that referenced this pull request Mar 17, 2020
@jacobperron
Fix LoadComposableNodes action so that loading happens asynchronously (…
c708352 
…#113) (#132)

Fixes #107.

Before, the first call to _load_in_sequence was not asynchronous, unlike it's recursive calls.
This change makes the first call asynchronous.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@jacobperron jacobperron

Labels
in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LoadComposableNodes action blocks previous actions
2 participants
@jacobperron @wjwwood