Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AttributeError when accessing component container name #177

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Fix AttributeError when accessing component container name #177

merged 1 commit into from
Oct 2, 2020

Conversation

jacobperron
Copy link
Member

self.__target_container is not necessarily an ExecuteProcess action, and therefore may not have a 'name' attribute.

@jacobperron
Fix AttributeError when accessing component container name
84fba8b 
`self.__target_container` is not necessarily an ExecuteProcess action, and therefore may not have a 'name' attribute.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added the bug Something isn't working label Sep 15, 2020
@jacobperron jacobperron self-assigned this Sep 15, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 3 via automation Sep 15, 2020
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 3 Sep 15, 2020
@jacobperron jacobperron mentioned this pull request Sep 16, 2020
Merged
@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 18be4d4 into master Oct 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/fix_get_container_name branch October 2, 2020 21:39
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 3 Oct 9, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 4 via automation Oct 9, 2020
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 4 Oct 9, 2020
jacobperron added a commit that referenced this pull request Nov 20, 2020
@jacobperron
Fix AttributeError when accessing component container name (#177)
1ec2032 
`self.__target_container` is not necessarily an ExecuteProcess action, and therefore may not have a 'name' attribute.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 4 Dec 11, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 5 via automation Dec 11, 2020
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 5 Dec 11, 2020
jacobperron added a commit that referenced this pull request May 25, 2021
@jacobperron
Fix AttributeError when accessing component container name (#177)
6760c7a 
`self.__target_container` is not necessarily an ExecuteProcess action, and therefore may not have a 'name' attribute.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request May 25, 2021
Merged
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 5 May 25, 2021
jacobperron added a commit that referenced this pull request May 27, 2021
@jacobperron
Fix AttributeError when accessing component container name (#177) (#241)
e6d8995 
`self.__target_container` is not necessarily an ExecuteProcess action, and therefore may not have a 'name' attribute.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@jacobperron jacobperron

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacobperron @wjwwood