Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RosTimer to extend TimerAction #248

Merged
merged 4 commits into from
Jun 21, 2021
Merged

Refactor RosTimer to extend TimerAction #248

merged 4 commits into from
Jun 21, 2021

Conversation

rebecca-butler
Copy link
Contributor

@rebecca-butler rebecca-butler commented Jun 16, 2021 •
edited
Loading

@rebecca-butler
Refactor RosTimer to extend TimerAction
b44e8f4 
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
@rebecca-butler rebecca-butler linked an issue Jun 16, 2021 that may be closed by this pull request
Refactor RosTimer to inherit from TimerAction #247
Closed
@rebecca-butler rebecca-butler mentioned this pull request Jun 17, 2021
Merged
@rebecca-butler
Remove unused import
0bb7d4a 
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
jacobperron
jacobperron reviewed Jun 17, 2021
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One minor suggestion. Also, see my other comment in the connected PR.

launch_ros/launch_ros/actions/ros_timer.py Outdated Show resolved Hide resolved
@rebecca-butler
Remove unused import
7569d39 
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
@rebecca-butler
Add _ prefix to variable names
5e0a5f0 
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
jacobperron
jacobperron approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would first merge the connected PR, then we can make a release into Rolling before merging this PR.

@rebecca-butler
Copy link
Contributor Author

@ros-pull-request-builder retest this please

@rebecca-butler rebecca-butler merged commit 58334b4 into master Jun 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the refactor_ros_timer_action branch June 21, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor RosTimer to inherit from TimerAction
2 participants
@rebecca-butler @jacobperron