Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider porting RewrittenYaml from Nav2 to allow param overrides to YAML from launch #258

Open
adamsj-ros opened this issue Jul 26, 2021 · 2 comments
Labels

Comments

@adamsj-ros
Copy link

Feature request

Consider porting RewrittenYaml from Nav2.

Feature description

The use case is using YAMLs for default params but allowing to override individual params from launch. The overwrites could be extended to an override yaml.

launch_ros.actions.Node(
        package='nodes',
        executable='node_exe',
        parameters=[
            path_to_yaml,
            # overwrite parameters from yaml here
            {"param_name": value}
        ]

This seems to almost work but with the limitation that the params specified in the YAML must be for all nodes. This is not ideal in the event params have the same name between nodes and you wish to distinguish.

Implementation considerations

This is a pretty nice way to override individual parameters in a YAML during launch. However, it only seems to work if the YAML file is set to for all nodes.

An alternative is Nav2's RewrittenYaml[link] feature but that requires to clone/install all of Nav2.

@SteveMacenski
Copy link

I'm happy to donate any and all work from Nav2 that would have more general use across the community. I'd love if this was here!

@hidmic
Copy link
Contributor

hidmic commented Dec 8, 2021

This seems to almost work but with the limitation that the params specified in the YAML must be for all nodes.

Right, because Node was not written with multi-node processes in mind.

#215 will indirectly address this issue by generalizing process execution via launch. It needs work still though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants