Add timeout to wait for service response in example #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
adityapande-1995
approved these changes
Sep 23, 2021
|
CI (build:
|
clalancette
reviewed
Sep 23, 2021
| @@ -69,7 +69,7 @@ def set_parameter(self, state=True, timeout=5.0): | |||
| request = SetParameters.Request() | |||
| request.parameters = parameters | |||
| future = client.call_async(request) | |||
| rclpy.spin_until_future_complete(self, future) | |||
| rclpy.spin_until_future_complete(self, future, timeout_sec=5.0) | |||
There was a problem hiding this comment.
There's already a timeout being passed to set_parameter, which seems to be totally unused right now. Should we use that instead?
There was a problem hiding this comment.
Use timeout parameter in 887ffac
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
|
CI re-run
|
clalancette
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix the occasional hang seen in https://ci.ros2.org/job/ci_windows/15468/ . If the service response isn't received by the client in 5 seconds then the test will exit.