Increase the timeout in wait_for_topic_launch_test. #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested review from
adityapande-1995 and
methylDragon
as code owners
|
CI:
|
mjcarroll
approved these changes
Aug 28, 2023
clalancette
deleted the
clalancette/wait-for-topics-test-increase-timeout
branch
|
Is there a more "robust" way to do this in CI without hard-coded delay? 10 seconds seems pretty long for a single discovery channel, no? We're facing the same issues with the delays in internal CI, except it's dropping samples and causing test failures in our system tests, which hang up our release pipelines to prod. More context on related issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 0c081a7 (#360) we increased the timeout to 10 seconds to accomodate slower discovery. However, this was partially reverted in
2d125a5
(#353).
Restore the 10 second timeout to avoid flakes on the buildfarm.