Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SetParametersFromFile to take several files #405

Open
tonynajjar opened this issue Jul 11, 2024 · 0 comments
Open

Allow SetParametersFromFile to take several files #405

tonynajjar opened this issue Jul 11, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@tonynajjar
Copy link

tonynajjar commented Jul 11, 2024

Feature request

Feature description

I use a hierarchical yaml configuration. I can pass several param files to the Nodes and they will handle the overriding. It would be nice if SetParametersFromFile could take a list of files as well to mirror that behavior.

Implementation considerations

Not sure how to do this in a backwards-compatible way since the input would need to change from a string to a list of strings. (And the Action probably needs to be renamed to SetParametersFromFiles (with an s)).
How about creating SetParametersFromFiles on the side and slowly deprecating SetParametersFromFile?

@cottsay cottsay added the help wanted Extra attention is needed label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants