Add pid to launch_ros node name as suffix #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
jacobperron
approved these changes
Nov 25, 2019
|
hidmic
reviewed
Nov 26, 2019
| @@ -61,7 +62,9 @@ def _function(self, context: launch.LaunchContext): | |||
| if 'rcl_init called while already initialized' in str(exc): | |||
| pass | |||
| raise | |||
| self.__launch_ros_node = rclpy.create_node('launch_ros', context=self.__rclpy_context) | |||
| self.__launch_ros_node = rclpy.create_node( | |||
| 'launch_ros_{}'.format(os.getpid()), | |||
There was a problem hiding this comment.
@BMarchi appending launch PID helps disambiguate but doesn't make it a hidden a node -- you need a leading underscore.
There was a problem hiding this comment.
I didn't see the requirement to make the launch_ros node hidden. Are you sure about appending that?
There was a problem hiding this comment.
Oops, I just tossed in a feature request. It's not in the original ticket, you're right. Disregard (I'll propose it afterwards).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2 . As the title says, it adds the pid to the node's name as a suffix. Is there any need to create a test for this?