Bump QD to 3 and some minor style fixes #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
20 tasks
Blast545
approved these changes
Jun 25, 2020
brawner
approved these changes
Jun 25, 2020
libyaml_q_declaration.md
Outdated
| @@ -10,9 +10,9 @@ The `libyaml` meets the basic requirements for a software platform in terms of t | |||
|
|
|||
| Even if the library does not provide an API/ABI policy targeting the desired use of the library, the fact that it deals with the YAML standard and this one hasn’t changed since 2009, allows us to infer that the functionality needed for the ROS core from this library is not going to be changed. | |||
|
|
|||
| There is no explicit support for any OS platform, however their [Github repository](https://github.com/yaml/libyaml) installation appears to be targeting Linux. The first version of this library was developed in 2006, and it is used widely. There is no explicit metric of how much the library is used, but the equivalent library for Python, developed by the same organization is required for at least 150k repositories (According to [Github metrics](https://github.com/yaml/pyyaml/network/dependents?package_id=UGFja2FnZS01MjUyMjEzNQ%3D%3D)) and the `libyaml` library is used for some optional fast functionality. The [safe_yaml](https://rubygems.org/gems/safe_yaml) ruby gem has over 80million downloads and one of its implementations uses `libyaml` through psych. It is also used in the [Go-yaml project](https://github.com/go-yaml/yaml), the project supporting Yaml in the Go language. | |||
| There is no explicit support for any OS platform, however their [Github repository](https://github.com/yaml/libyaml) installation appears to be targeting Linux. The first version of this library was developed in 2006, and it is used widely. There is no explicit metric of how much the library is used, but the equivalent library for Python, developed by the same organization is required for at least 150k repositories (According to [Github metrics](https://github.com/yaml/pyyaml/network/dependents?package_id=UGFja2FnZS01MjUyMjEzNQ%3D%3D)) and the `libyaml` library is used for some optional fast functionality. The [safe_yaml](https://rubygems.org/gems/safe_yaml) ruby gem has over 80million downloads and one of its implementations uses `libyaml` through psych. It is also used in the [Go-yaml project](https://github.com/go-yaml/yaml), the project supporting YAML in the Go language. | |||
There was a problem hiding this comment.
While you're editing this paragraph, could you switch it to use one sentence per line so that new PRs can have easier to read diffs? I honestly can't tell what changed with a quick glance.
There was a problem hiding this comment.
For cases like this one in particular, I use the "show rich diff" option within Github, and that highlights the changes.
There was a problem hiding this comment.
I changed Yaml -> YAML
Signed-off-by: ahcorde <ahcorde@gmail.com>
Blast545
approved these changes
Jun 26, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
brawner
reviewed
Jun 29, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
brawner
approved these changes
Jun 29, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
brawner
approved these changes
Jun 29, 2020
ahcorde
added a commit
to ahcorde/libyaml_vendor
that referenced
this pull request
Oct 29, 2020
* Bump QD to 3 and some minor fixed * Added feedback * Sentences on separate lines to help minimize diffs * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com>
cottsay
pushed a commit
that referenced
this pull request
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brawner @Blast545
Signed-off-by: ahcorde ahcorde@gmail.com