Fixes pointed out by clang #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
clalancette
commented
Nov 13, 2023
clalancette
commented
- Make one of the SubscriptionBase::subscribe methods pure virtual. That's because it only ever called itself, which is nonsensical. That just means that all classes that derive from it must implement it.
- Make clang aware that one of the tests here just wants to test that equality doesn't throw, so we don't care about the result.
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
As it stood, it was only ever calling itself, which was pointed out by clang as an infinite recursion. It only makes sense if a downstream class overrides this method, so mark it as pure virtual here. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.