Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RCL_ROS_TIME for message_traits::TimeStamp for Foxy #81

Merged
merged 1 commit into from May 15, 2023
Merged

Use RCL_ROS_TIME for message_traits::TimeStamp for Foxy #81

merged 1 commit into from May 15, 2023

Conversation

pschalkwijk
Copy link

Also taken from the rolling branch

  • when creating TimeStamp, make sure RCL_ROS_TIME is being used, and not RCL_SYSTEM_TIME.

Signed-off-by: Kenji Brameld kenjibrameld@gmail.com

  • Update include/message_filters/message_traits.h

Co-authored-by: Sivert Havso sivert@havso.net

  • add test to ensure message_filters::message_traits::TimeStamp::value returns a time with RCL_ROS_TIME time source

Signed-off-by: Kenji Brameld kenjibrameld@gmail.com

Co-authored-by: Sivert Havso sivert@havso.net

@ijnek @SivertHavso
Use RCL_ROS_TIME for message_traits::TimeStamp (ros2#72)
56fbdee 
* when creating TimeStamp, make sure RCL_ROS_TIME is being used, and not RCL_SYSTEM_TIME.

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>

* Update include/message_filters/message_traits.h

Co-authored-by: Sivert Havso <sivert@havso.net>

* add test to ensure message_filters::message_traits::TimeStamp<Msg>::value returns a time with RCL_ROS_TIME time source

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>

Co-authored-by: Sivert Havso <sivert@havso.net>
@gbiggs
Copy link
Member

gbiggs commented Jul 19, 2022

This appears to be changing the behaviour of an API. Can you please explain what you are expecting from this change and why it is appropriate to backport it to Foxy?

@clalancette clalancette added the more-information-needed Further information is required label Aug 4, 2022
@ralwing
Copy link

ralwing commented Dec 7, 2022

FYI This is a backport of #72

@quarkytale quarkytale added this to Proposed in Foxy Patch Release 11 May 1, 2023
@quarkytale
Copy link

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette moved this from Proposed to In progress in Foxy Patch Release 11 May 15, 2023
@quarkytale quarkytale merged commit fbf07db into ros2:foxy May 15, 2023
@quarkytale quarkytale moved this from In progress to Needs release in Foxy Patch Release 11 May 15, 2023
@clalancette clalancette mentioned this pull request May 23, 2023
Merged
@quarkytale quarkytale moved this from Needs release to Done in Foxy Patch Release 11 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quarkytale quarkytale quarkytale approved these changes

Assignees
No one assigned
Labels
more-information-needed Further information is required
Projects
No open projects
Foxy Patch Release 11
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pschalkwijk @gbiggs @ralwing @quarkytale @clalancette @ijnek