Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the commit that fixes the executable stack. #32

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

clalancette
Copy link
Contributor

See ros2/Mimick#26 for more information.

Still a draft since I need to test out the aarch64 changes in CI.

@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette changed the title Update to the comment that fixes the executable stack. Update to the commit that fixes the executable stack. Jul 20, 2023
@clalancette clalancette marked this pull request as ready for review July 20, 2023 17:56
@clalancette
Copy link
Contributor Author

Here is clang and RHEL as well:

  • RHEL Build Status
  • Clang Build Status

See ros2/Mimick#26 for more
information.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette force-pushed the clalancette/fix-executable-stack branch from 4851fa1 to 02c47a7 Compare August 1, 2023 12:50
@clalancette
Copy link
Contributor Author

OK, ros2/Mimick#26 has been merged, and I've now updated this one to point to the head of that repository. So this should be good to go for a review and merge.

@clalancette
Copy link
Contributor Author

And one more CI just to check that I didn't mess up the hash:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@clalancette clalancette merged commit 24f0be6 into rolling Aug 1, 2023
2 checks passed
@clalancette clalancette deleted the clalancette/fix-executable-stack branch August 1, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants