Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update performance_test_fixture to C++17. #21

Merged
merged 1 commit into from Jan 30, 2023
Merged

Update performance_test_fixture to C++17. #21

merged 1 commit into from Jan 30, 2023

Commits on Jan 27, 2023

  1. Update performance_test_fixture to C++17. 

    The two reasons to do this are:

1. So that we can compile performance_test_fixture
   with the clang static analyzer. As of clang++-14
   (what is in Ubuntu 22.04), the default still seems
   to be C++14, so we need to specify C++17 so that new
   things in the rclcpp headers work properly.
2. So we can build with a newer version of gtest which requires this.

Further, due to reasons I don't fully understand, I needed to
set CMAKE_CXX_STANDARD_REQUIRED in order for clang to really use
that version. So set this as well.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    efd76d7 View commit details
    Browse the repository at this point in the history