Skip to content

Commit

Permalink
Revert "Add tests enclave_name"
Browse files Browse the repository at this point in the history
Being tested in another branch

This reverts commit 31d6684.

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
  • Loading branch information
Blast545 committed Jun 16, 2020
1 parent 31d6684 commit 2e0f073
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions rcl/test/rcl/test_validate_enclave_name.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ TEST(TestValidateEnclaveName, test_validate) {
RCL_RET_OK,
rcl_validate_enclave_name("/foo", &validation_result, &invalid_index));
EXPECT_EQ(RCL_ENCLAVE_NAME_VALID, validation_result);
EXPECT_EQ(NULL, rcl_enclave_name_validation_result_string(validation_result));

EXPECT_EQ(
RCL_RET_OK,
Expand All @@ -57,20 +56,15 @@ TEST(TestValidateEnclaveName, test_validation_string) {
int expected_validation_result;
size_t expected_invalid_index;
};
std::string longString = "/looooooooooooooooooooooooooooooooooooooooooooooooo"
"oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo"
"oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo"
"oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo"
"ooooooooooooooooooooooooooooongString";
std::vector<enclave_case> enclave_cases_that_should_fail = {
// TODO(blast_545): Look for naming conventions doc for enclave_names
{"", RCL_ENCLAVE_NAME_INVALID_IS_EMPTY_STRING, 0},
{"~/foo", RCL_ENCLAVE_NAME_INVALID_NOT_ABSOLUTE, 0},
{"/foo/", RCL_ENCLAVE_NAME_INVALID_ENDS_WITH_FORWARD_SLASH, 4},
{"/foo/$", RCL_ENCLAVE_NAME_INVALID_CONTAINS_UNALLOWED_CHARACTERS, 5},
{"/bar#", RCL_ENCLAVE_NAME_INVALID_CONTAINS_UNALLOWED_CHARACTERS, 4},
{"/foo//bar", RCL_ENCLAVE_NAME_INVALID_CONTAINS_REPEATED_FORWARD_SLASH, 5},
{"/1bar", RCL_ENCLAVE_NAME_INVALID_NAME_TOKEN_STARTS_WITH_NUMBER, 1},
{longString, RCL_ENCLAVE_NAME_INVALID_TOO_LONG, RCL_ENCLAVE_NAME_MAX_LENGTH - 1}
{"/1bar", RCL_ENCLAVE_NAME_INVALID_NAME_TOKEN_STARTS_WITH_NUMBER, 1}
};
for (const auto & case_tuple : enclave_cases_that_should_fail) {
std::string enclave = case_tuple.enclave;
Expand Down

0 comments on commit 2e0f073

Please sign in to comment.