Add send_response logging

ros2 · Nov 21, 2017 · 7c7e117 · 7c7e117
1 parent bbece9e
commit 7c7e117
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/rcl/src/rcl/client.c b/rcl/src/rcl/client.c
@@ -238,6 +238,7 @@ RCL_WARN_UNUSED
 rcl_ret_t
 rcl_send_request(const rcl_client_t * client, const void * ros_request, int64_t * sequence_number)
 {
+  RCUTILS_LOG_DEBUG_NAMED(ROS_PACKAGE_NAME, "Client sending service request")
   if (!rcl_client_is_valid(client)) {
     return RCL_RET_CLIENT_INVALID;
   }
@@ -263,6 +264,7 @@ rcl_take_response(
   rmw_request_id_t * request_header,
   void * ros_response)
 {
+  RCUTILS_LOG_DEBUG_NAMED(ROS_PACKAGE_NAME, "Client taking service response")
   if (!rcl_client_is_valid(client)) {
     return RCL_RET_CLIENT_INVALID;
   }
@@ -279,7 +281,7 @@ rcl_take_response(
     return RCL_RET_ERROR;
   }
   RCUTILS_LOG_DEBUG_NAMED(
-    ROS_PACKAGE_NAME, "Client take request succeeded: %s", taken ? "true" : "false")
+    ROS_PACKAGE_NAME, "Client take response succeeded: %s", taken ? "true" : "false")
   if (!taken) {
     return RCL_RET_CLIENT_TAKE_FAILED;
   }

diff --git a/rcl/src/rcl/service.c b/rcl/src/rcl/service.c
@@ -245,6 +245,7 @@ rcl_take_request(
   rmw_request_id_t * request_header,
   void * ros_request)
 {
+  RCUTILS_LOG_DEBUG_NAMED(ROS_PACKAGE_NAME, "Service server taking service request")
   const rcl_service_options_t * options = rcl_service_get_options(service);
   RCL_CHECK_ARGUMENT_FOR_NULL(request_header, RCL_RET_INVALID_ARGUMENT, options->allocator);
   RCL_CHECK_ARGUMENT_FOR_NULL(ros_request, RCL_RET_INVALID_ARGUMENT, options->allocator);
@@ -270,6 +271,7 @@ rcl_send_response(
   rmw_request_id_t * request_header,
   void * ros_response)
 {
+  RCUTILS_LOG_DEBUG_NAMED(ROS_PACKAGE_NAME, "Sending service response")
   const rcl_service_options_t * options = rcl_service_get_options(service);
   RCL_CHECK_ARGUMENT_FOR_NULL(request_header, RCL_RET_INVALID_ARGUMENT, options->allocator);
   RCL_CHECK_ARGUMENT_FOR_NULL(ros_response, RCL_RET_INVALID_ARGUMENT, options->allocator);
@@ -280,7 +282,6 @@ rcl_send_response(
     RCL_SET_ERROR_MSG(rmw_get_error_string_safe(), options->allocator);
     return RCL_RET_ERROR;
   }
-
   return RCL_RET_OK;
 }