Make sure to reset errors more places in the tests. #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so we don't get as many warnings when the tests are running. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so we don't get as many warnings when the tests are running.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Note that this does not get rid of all warnings; there are quite a few still remaining, and those mostly involve actual bugs in our error handling. Nevertheless, I think this is worthwhile to get in for our sanity, and to make those other bugs more visible.