Runtime Interface Reflection: rcl #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methylDragon
force-pushed
the
runtime_interface_reflection
branch
2 times, most recently
from
de39734
to
f12e5a7
Compare
31 tasks
methylDragon
force-pushed
the
runtime_interface_reflection
branch
3 times, most recently
from
0828ab6
to
e87aa66
Compare
methylDragon
force-pushed
the
runtime_interface_reflection
branch
2 times, most recently
from
bdfd5a5
to
51423ad
Compare
methylDragon
force-pushed
the
runtime_interface_reflection
branch
4 times, most recently
from
8d01f92
to
b71cb87
Compare
methylDragon
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
methylDragon
force-pushed
the
runtime_interface_reflection
branch
3 times, most recently
from
06745c8
to
318f951
Compare
methylDragon
force-pushed
the
runtime_interface_reflection
branch
10 times, most recently
from
aaf7e0d
to
dd7b5a1
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
runtime_interface_reflection
branch
from
9dde04c
to
0d6a665
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
wjwwood
requested changes
Apr 7, 2023
There was a problem hiding this comment.
lgtm aside from wanting to double check on some lingering TODO's. It's ok to have TODO's and merge this, I just want to check that they are still valid before merging.
Specifically there's some business related to type_description_interfaces__msg__TypeDescription vs rosidl_runtime_c__type_description__TypeDescription that I'm not sure about whether or not there is anything left to do or if the TODO's surrounding them can just be dropped.
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
wjwwood
approved these changes
Apr 8, 2023
achim-k
pushed a commit
to achim-k/rcl
that referenced
this pull request
Apr 10, 2023
* Implement runtime type typesupport struct Signed-off-by: methylDragon <methylDragon@gmail.com> * Implement first cut Signed-off-by: methylDragon <methylDragon@gmail.com> * Migrate to rosidl_dynamic_typesupport and update field IDs Signed-off-by: methylDragon <methylDragon@gmail.com> * Migrate to type description interfaces Signed-off-by: methylDragon <methylDragon@gmail.com> * Fix const Signed-off-by: methylDragon <methylDragon@gmail.com> * Refine signatures and use return types Signed-off-by: methylDragon <methylDragon@gmail.com> * Fix C linkage Signed-off-by: methylDragon <methylDragon@gmail.com> * Migrate methods to use return types Signed-off-by: methylDragon <methylDragon@gmail.com> * Lint Signed-off-by: methylDragon <methylDragon@gmail.com> * Support type hashes Signed-off-by: methylDragon <methylDragon@gmail.com> * Remove identifier alias Signed-off-by: methylDragon <methylDragon@gmail.com> * Change fini to destroy Signed-off-by: methylDragon <methylDragon@gmail.com> * Use create instead of init Signed-off-by: methylDragon <methylDragon@gmail.com> * Add rcutils conversion function and remove rmw interfaces Signed-off-by: methylDragon <methylDragon@gmail.com> * Clean up some comments Signed-off-by: methylDragon <methylDragon@gmail.com> --------- Signed-off-by: methylDragon <methylDragon@gmail.com>
danthony06
pushed a commit
to danthony06/rcl
that referenced
this pull request
Jun 14, 2023
* Implement runtime type typesupport struct Signed-off-by: methylDragon <methylDragon@gmail.com> * Implement first cut Signed-off-by: methylDragon <methylDragon@gmail.com> * Migrate to rosidl_dynamic_typesupport and update field IDs Signed-off-by: methylDragon <methylDragon@gmail.com> * Migrate to type description interfaces Signed-off-by: methylDragon <methylDragon@gmail.com> * Fix const Signed-off-by: methylDragon <methylDragon@gmail.com> * Refine signatures and use return types Signed-off-by: methylDragon <methylDragon@gmail.com> * Fix C linkage Signed-off-by: methylDragon <methylDragon@gmail.com> * Migrate methods to use return types Signed-off-by: methylDragon <methylDragon@gmail.com> * Lint Signed-off-by: methylDragon <methylDragon@gmail.com> * Support type hashes Signed-off-by: methylDragon <methylDragon@gmail.com> * Remove identifier alias Signed-off-by: methylDragon <methylDragon@gmail.com> * Change fini to destroy Signed-off-by: methylDragon <methylDragon@gmail.com> * Use create instead of init Signed-off-by: methylDragon <methylDragon@gmail.com> * Add rcutils conversion function and remove rmw interfaces Signed-off-by: methylDragon <methylDragon@gmail.com> * Clean up some comments Signed-off-by: methylDragon <methylDragon@gmail.com> --------- Signed-off-by: methylDragon <methylDragon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: ros2/ros2#1374
Implements new rosidl_message_type_support_t for runtime interface reflection