Use TRACETOOLS_ prefix for tracepoint-related macros #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophebedard
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
|
Holding off on this until after Iron branches off from Rolling (April 24th). |
christophebedard
force-pushed
the
christophebedard/add-namespace-prefix-tracetools-macros
branch
from
268236e
to
2747c64
Compare
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
christophebedard
force-pushed
the
christophebedard/add-namespace-prefix-tracetools-macros
branch
from
2747c64
to
88a23ff
Compare
|
This is ready for a review now that the Iron dust has settled a bit. |
|
@mjcarroll would you be able to review/approve this one? |
mjcarroll
approved these changes
Jun 8, 2023
christophebedard
deleted the
christophebedard/add-namespace-prefix-tracetools-macros
branch
danthony06
pushed a commit
to danthony06/rcl
that referenced
this pull request
Jun 14, 2023
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ros2/ros2_tracing#18
Requires ros2/ros2_tracing#56
Signed-off-by: Christophe Bedard bedard.christophe@gmail.com