Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comment #1073

Merged
merged 2 commits into from Jun 2, 2023
Merged

fix comment #1073

merged 2 commits into from Jun 2, 2023

Conversation

iuhilnehc-ynos
Copy link
Collaborator

Just a tiny fix

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
rcl/include/rcl/subscription.h Outdated Show resolved Hide resolved
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@iuhilnehc-ynos
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 1cb1209 into ros2:rolling Jun 2, 2023
3 checks passed
Acuadros95 pushed a commit to micro-ROS/rcl that referenced this pull request Jun 6, 2023
* fix comment

Signed-off-by: Chen Lihui <lihui.chen@sony.com>

* address comment

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>

---------

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Acuadros95 pushed a commit to micro-ROS/rcl that referenced this pull request Jun 6, 2023
* fix comment

Signed-off-by: Chen Lihui <lihui.chen@sony.com>

* address comment

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>

---------

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
danthony06 pushed a commit to danthony06/rcl that referenced this pull request Jun 14, 2023
* fix comment

Signed-off-by: Chen Lihui <lihui.chen@sony.com>

* address comment

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>

---------

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants