New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix comment #1073
Merged
Merged
fix comment #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuhilnehc-ynos
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
May 29, 2023 23:29
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
fujitatomoya
approved these changes
May 30, 2023
clalancette
requested changes
Jun 1, 2023
Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com>
clalancette
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with green CI.
Acuadros95
pushed a commit
to micro-ROS/rcl
that referenced
this pull request
Jun 6, 2023
* fix comment Signed-off-by: Chen Lihui <lihui.chen@sony.com> * address comment Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> --------- Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Acuadros95
pushed a commit
to micro-ROS/rcl
that referenced
this pull request
Jun 6, 2023
* fix comment Signed-off-by: Chen Lihui <lihui.chen@sony.com> * address comment Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> --------- Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
danthony06
pushed a commit
to danthony06/rcl
that referenced
this pull request
Jun 14, 2023
* fix comment Signed-off-by: Chen Lihui <lihui.chen@sony.com> * address comment Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> --------- Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tiny fix