improve error msg of rcl_expand_topic_name
#1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `RCL_RET_TOPIC_NAME_INVALID` is returned the error msg is obtained by calling `rcl_topic_name_validation_result_string` to ease debugging invalid topics. Signed-off-by: Eric Wolf <ewolf@advitec.de>
fujitatomoya
approved these changes
Jun 9, 2023
|
CI:
|
mjcarroll
approved these changes
Jun 9, 2023
|
https://ci.ros2.org/job/ci_linux-aarch64/13422/testReport/junit/projectroot.test/rclcpp/test_executors/ is unrelated, i will go ahead to merge this. |
danthony06
pushed a commit
to danthony06/rcl
that referenced
this pull request
Jun 14, 2023
If `RCL_RET_TOPIC_NAME_INVALID` is returned the error msg is obtained by calling `rcl_topic_name_validation_result_string` to ease debugging invalid topics. Signed-off-by: Eric Wolf <ewolf@advitec.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
RCL_RET_TOPIC_NAME_INVALIDis returned the error msg is obtained by callingrcl_topic_name_validation_result_stringto ease debugging invalid topics.I think this change would be useful because currently I have to debug erratically failing subscription initialisations at work and having a more specific error message would help a lot in understanding what went wrong in the future.