Cleanup error reporting in the type hash code. #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, using the RCL_CHECK_* macros in both rcl_node_type_cache_register_type() and rcl_convert_type_description_runtime_to_msg() meant that we would overwrite the error message of the latter in the former. This would end up with an rcutils warning about losing error messages Avoid that by just doing an open-coded check for NULL if rcl_node_type_cache_register_type(), passing along the error we got from the lower layers. While we are in here, also very slightly revamp the client_init code to not have two separate calls to type_support->get_type_hash_func(). Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
I should also say that this is the first in a large-ish series of patches that will reduce |
fujitatomoya
approved these changes
Aug 2, 2023
|
CI:
|
emersonknapp
approved these changes
Aug 3, 2023
Ah, I should have been more clear. The error message handling code does incur a bit of overhead, but that wasn't the main thing that allowed me to remove time. This (and a whole host of other patches to come) were mostly just things I noticed while shrinking the time down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, using the RCL_CHECK_* macros in both rcl_node_type_cache_register_type() and
rcl_convert_type_description_runtime_to_msg() meant that we would overwrite the error message of the latter in the former. This would end up with an rcutils warning about losing error messages
Avoid that by just doing an open-coded check for NULL if rcl_node_type_cache_register_type(), passing along the error we got from the lower layers.
While we are in here, also very slightly revamp the client_init code to not have two separate calls to type_support->get_type_hash_func().