Shorten wait time for a subscription not being ready. #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't wait around for 10 seconds for a subscription to not be ready; that can take literally forever. Instead, just wait one second. While we are in here, also make the case where we *are* waiting for a subscription to be ready more reactive by reducing the wait time to 100ms, with more tries. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
|
CI:
|
fujitatomoya
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't wait around for 10 seconds for a subscription to not be ready; that can take literally forever. Instead, just wait one second. While we are in here, also make the case where we are waiting for a subscription to be ready more reactive by reducing the wait time to 100ms, with more tries.