Simplify local_namespace handling in rcl_node_init. #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a comment in there about avoiding a memory allocation, but that doesn't seem to make much sense to me; we are going to be doing an allocation directly below, so avoiding it here seems unnecessary and makes the code harder to follow. Simplify everything by always making an allocation Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
fujitatomoya
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
makes sense to me.
i think it allocated the memory for "/" anyway (if we really want to avoid memory allocation, i would store it in the code area)... instead of this, we can go straight-forward to keep it simple. besides, this is one of the configuration APIs.
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a comment in there about avoiding a memory allocation, but that doesn't seem to make much sense to me; we are going to be doing an allocation directly below, so avoiding it here seems unnecessary and makes the code harder to follow. Simplify everything by always making an allocation