New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Just remove rcpputils::fs dependency #1105
Conversation
Signed-off-by: Kenta Yonekura <yoneken@ieee.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clalancette can we remove test_depend
from rcpputils
in package.xml?
Oh, that's a good point. After this PR, I don't think we need it anymore, so we can remove it both from the package.xml and from the CMakeLists.txt. |
@yoneken can you address #1105 (comment)? thanks in advance. |
Signed-off-by: Kenta Yonekura <yoneken@ieee.org>
Thanks for the comments! |
Because the package will be no longer available. ros2/rcpputils#164