Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AMENT_DEPENDENCIES from rcl_add_custom_gtest. #1119

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Remove AMENT_DEPENDENCIES from rcl_add_custom_gtest. #1119

merged 1 commit into from
Nov 27, 2023

Conversation

clalancette
Copy link
Contributor

There are no more users of it.

@clalancette
Remove AMENT_DEPENDENCIES from rcl_add_custom_gtest.
dde4730 
There are no more users of it.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

clalancette commented Nov 22, 2023 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after cc0cd52, no user.

@clalancette clalancette merged commit 62871dd into rolling Nov 27, 2023
2 of 3 checks passed
@clalancette clalancette deleted the clalancette/remove-ament-deps branch November 27, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clalancette @fujitatomoya