document out parameters for rcl_get_node_names and rcl_get_node_names_with_enclaves

[FelixPe]

No description provided.

[clalancette]

Thanks for these improvements.

I've left a few wording changes.

[clalancette]

Sorry, two more changes for the linters, then I'll run CI.

[FelixPe]

@clalancette Regarding the rcl_allocator_t parameter for rcl_get_node_names in graph.h it looks inconsistent to me: Why is it given for rcl_get_topic_names_and_types as pointer type rcl_allocator_t* ?

(The allocator is not yet in use for rcl_get_node_names, but it might improve consistency to switch to the pointer type here as well.)

[clalancette]

@clalancette Regarding the rcl_allocator_t parameter for rcl_get_node_names in graph.h it looks inconsistent to me: Why is it given for rcl_get_topic_names_and_types as pointer type rcl_allocator_t* ?

This is an ongoing discussion; see #264 . There are tradeoffs between having the parameter be a pointer (where we only have to copy the pointer, but then have to check for NULL pointer in the callee), and having the parameter be a structure (where we have to copy the whole structure, but then don't have to check for NULL in the callee). We still haven't resolved it one way or the other, so I don't think we should get bogged down in it here.

[clalancette]

CI:

• Linux
• Linux-aarch64
• Windows

[fujitatomoya]

lgtm with green CI