Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Minor style improvements #1147

Merged
merged 1 commit into from Apr 9, 2024

Conversation

jmachowinski
Copy link
Contributor

followup to #1146

These are just style changes suggested by @alsora that I pushed on the wrong branch, and thus did not end up in the PR.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you mind to sign the commit ?

Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com>
@jmachowinski
Copy link
Contributor Author

LGTM, do you mind to sign the commit ?

fixed

@ahcorde
Copy link
Contributor

ahcorde commented Apr 8, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@jmachowinski
Copy link
Contributor Author

Can we merge this ?

@ahcorde ahcorde merged commit 3c7cb78 into ros2:rolling Apr 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants