reset error message before setting a new one, embed the original one #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
added
bug
Karsten1987
approved these changes
Sep 16, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
|
Linter warnings addressed in fb5b56b. |
delete-merged-branch
bot
deleted the
dirk-thomas/lifecycle-error-msgs
branch
zmichaels11
pushed a commit
to zmichaels11/rcl
that referenced
this pull request
Sep 20, 2019
…os2#501) * reset error message before setting a new one, embed the original one Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * fix max line length Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported in ros-navigation/navigation2#1079 (comment)
Prevents to overwrite the error state.
CI builds testing
--packages-above rcl-lifecycle: