[rcl lifecycle] removed rmw_implementation from package.xml #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
lgtm, with CI.
I'd like @dirk-thomas to look at it as well though, in case I'm forgetting a reason why it is needed.
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
ahcorde
force-pushed
the
ahcorde/fix_depdendencies
branch
from
f1f2ad5
to
1b37026
Compare
|
|
rcl/rcl_lifecycle/src/com_interface.c Lines 34 to 35 in c601464 rosidl_generator_c so I don't think the dependency on it can be removed.
@ahcorde Please update the title (which will become the squashed commit message) to describe the actual change. As is it is not saying anything useful. |
ahcorde
changed the title
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
|
|
|
wjwwood
approved these changes
Feb 26, 2020
|
unrelated failures. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rcl_lifecycle package
<build_depend>and<exec_depends>onrmw_implementationI'm not sure about
<exec_depends>. But<build_depend>looks more reasonable to includermwinstead ofrmw_implementationbecausermwis been used in the CMakeLists.txtAnother thing is that "rosidl_generator_c" is set as a
<build depend>and<exec_depends>but then in the CMakeLists.txt is not beenfind_packageRemoved
rosidl_generator_cdependency