New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport dashing] Don't check history depth if RMW_QOS_POLICY_HISTORY_KEEP_ALL #595
Conversation
Backport of ros2#593 Fixes CI issue http://build.ros2.org/user/rotu/my-views/view/CycloneDDS/job/Dci__nightly-cyclonedds_ubuntu_bionic_amd64/lastCompletedBuild/testReport/rcl/TestWithDifferentQoSSettings_TestGetActualQoS__rmw_cyclonedds_cpp/test_publisher_get_qos_settings_publisher_non_default_qos__publisher_non_default_qos______________________/ Signed-off-by: Dan Rose <dan@digilabs.io>
@jacobperron, could you please review? |
Please first get the original PR reviewed and merged before opening backport PRs. Also mark them in the title a bit clearer (I just updated it) and also when doing backports do target all active distros is applicable - in this case Eloquent. |
* Backport guidelines As per ros2/rcl#595 (comment) * Address review feedback
Though backporting a test is not super useful, it will clean up the current build failures: http://build.ros2.org/view/Dci/job/Dci__nightly-cyclonedds_ubuntu_bionic_amd64/207/testReport/junit/rcl/TestWithDifferentQoSSettings_TestGetActualQoS__rmw_cyclonedds_cpp/test_publisher_get_qos_settings_publisher_non_default_qos__publisher_non_default_qos______________________/ The original PR was already merged and the checker is passing, merging this one too. |
* Backport guidelines As per ros2/rcl#595 (comment) * Address review feedback
Backport of #593
Fixes CI issue http://build.ros2.org/user/rotu/my-views/view/CycloneDDS/job/Dci__nightly-cyclonedds_ubuntu_bionic_amd64/lastCompletedBuild/testReport/rcl/TestWithDifferentQoSSettings_TestGetActualQoS__rmw_cyclonedds_cpp/test_publisher_get_qos_settings_publisher_non_default_qos__publisher_non_default_qos______________________/
Signed-off-by: Dan Rose dan@digilabs.io