Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality Declarations for rcl_action, rcl_lifecycle, yaml_parser #641

Merged
merged 4 commits into from
May 7, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented May 1, 2020

As part of the effort to push to Quality Level 1, this adds quality declarations for rcl_action, rcl_lifecycle, and rcl_yaml_param_parser.

Signed-off-by: Stephen Brawner brawner@gmail.com

…parser

Signed-off-by: Stephen Brawner <brawner@gmail.com>
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor fixes

rcl_action/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl_action/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl_lifecycle/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl_lifecycle/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl_lifecycle/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl_action/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl_yaml_param_parser/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl_yaml_param_parser/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl_yaml_param_parser/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner force-pushed the brawner/quality_declarations branch from 420a073 to 7f94785 Compare May 4, 2020 18:07
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider to add a small description in the dependencies section for each package.

rcl_action/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide a better description for msg packages

rcl_action/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl_lifecycle/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@ahcorde ahcorde merged commit 728b8b8 into master May 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/quality_declarations branch May 7, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants