Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set transition_map->states/transition size to 0 on fini #729

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Set transition_map->states/transition size to 0 on fini #729

merged 1 commit into from
Aug 12, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Jul 29, 2020

This was discovered during fault injection tests. But states_size and transititions_size need to be set to 0 on finalization because if finalization is ever called again, the for loop is entered without checking if states is null.

Signed-off-by: Stephen Brawner brawner@gmail.com

@brawner brawner self-assigned this Jul 29, 2020
@brawner brawner mentioned this pull request Jul 29, 2020
Merged
fujitatomoya
fujitatomoya approved these changes Jul 29, 2020
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brawner
Set transition_map->states/transition size to 0 on fini
bf21179 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner force-pushed the brawner/rcl_lifecycle-states-size branch from 5ee4d06 to bf21179 Compare August 12, 2020 19:39
@brawner
Copy link
Contributor Author

brawner commented Aug 12, 2020

Rebased onto master

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@brawner brawner requested a review from hidmic August 12, 2020 19:40
@brawner brawner added this to Proposed in Foxy Patch Release 3 via automation Aug 12, 2020
@brawner brawner moved this from Proposed to Needs backport in Foxy Patch Release 3 Aug 12, 2020
hidmic
hidmic approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brawner
Copy link
Contributor Author

brawner commented Aug 12, 2020

Thanks for the reviews!

@brawner brawner merged commit f90c01c into master Aug 12, 2020
@brawner brawner deleted the brawner/rcl_lifecycle-states-size branch August 28, 2020 00:26
brawner added a commit that referenced this pull request Oct 5, 2020
@brawner
Set transition_map->states/transition size to 0 on fini (#729)
9f18604 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner mentioned this pull request Oct 5, 2020
Merged
@brawner brawner removed this from Needs backport in Foxy Patch Release 3 Oct 5, 2020
brawner added a commit that referenced this pull request Oct 5, 2020
@brawner
Set transition_map->states/transition size to 0 on fini (#729) (#821)
34107de 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

@hidmic hidmic hidmic approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@brawner brawner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brawner @Karsten1987 @hidmic @fujitatomoya