Add lifecycle node state transition instrumentation #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
christophebedard
force-pushed
the
add-lifecycle-node-state-transition-instrumentation
branch
from
d657a60
to
70f728e
Compare
jacobperron
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
LGTM
Running CI with https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/merge_requests/199:
- Linux
- Linux-aarch64
- macOS
- Windows
We should hold this PR until https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/merge_requests/199 is merged and released in to rolling (then the Rpr job should pass).
fujitatomoya
approved these changes
Oct 13, 2020
rosdistro PR: ros/rosdistro#26933 |
|
@ros-pull-request-builder retest this please |
christophebedard
deleted the
add-lifecycle-node-state-transition-instrumentation
branch
Barry-Xu-2018
pushed a commit
to Barry-Xu-2018/rcl
that referenced
this pull request
Oct 29, 2020
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This instrumentation is used to track state transitions of lifecycle nodes.
Requires https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/merge_requests/199
For an example of processed/output data, see https://gitlab.com/micro-ROS/ros_tracing/tracetools_analysis/-/merge_requests/83