[rcl_lifecycle] Add warnings #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fujitatomoya
approved these changes
Oct 14, 2020
|
Hi @fujitatomoya, for the next ROS2 release, we want to add several warnings to all of the maintained C and C++ packages. The thinking is that this will help maintain code quality and catch bugs (it has already caught a few in other packages). I made a proposal and worked with the team to find a set of warnings to include. I'll ask if I can make the proposal public. Below is the full set of warnings. This PR doesn't do all of them because some of the warnings require solving additional problems (so far, mostly to do with vendor packages, like googletest). |
|
sounds great 👍 thanks 😃 |
clalancette
requested changes
Oct 14, 2020
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
audrow
force-pushed
the
audrow/add-warnings-rcl_lifecycle
branch
from
255312d
to
d159f26
Compare
|
I also tested above packages to see if changing the type of
|
clalancette
approved these changes
Oct 21, 2020
delete-merged-branch
bot
deleted the
audrow/add-warnings-rcl_lifecycle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
-Wformat=2,-Wconversion,-Wshadow, and-Wsign-conversioninrcl_lifecycle. This PR relies on using gtest v1.10.0, see ament/googletest#8.