Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set symbol visibility to hidden for rcl #391

Merged
merged 4 commits into from
Mar 6, 2019
Merged

Set symbol visibility to hidden for rcl #391

merged 4 commits into from
Mar 6, 2019

Commits on Feb 26, 2019

  1. Set symbol visibility to hidden for rcl 

    Enabling symbol visibility feature in gcc and clang compilers.
This will hep find symbol export related issues in linux and
potentially reduce compile times.

Discourse topic link:
https://discourse.ros.org/t/set-symbol-visibility-to-hidden-for-rmw-and-rcl-packages/7981

Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
    @bhatsach
    bhatsach committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    1a4f48e View commit details
    Browse the repository at this point in the history

  2. Remove WIN specific compiler definition in configure_rcl 

    Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
    @bhatsach
    bhatsach committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    67e851e View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. Rename macro name rcl_set_symbol_visibility_hidden 

    Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
    @bhatsach
    bhatsach committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    d49a8e9 View commit details
    Browse the repository at this point in the history

  2. Change macro to args for rcl_set_symbol_visibility_hidden 

    Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
    @bhatsach
    bhatsach committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    b6e770b View commit details
    Browse the repository at this point in the history