Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add array parameter types as defined in https://github.com/ros2/design/pull/152 #32

Merged
merged 3 commits into from May 10, 2018

Conversation

mikaelarguedas
Copy link
Member

This is to support @ayrton04's work on implementing parameter arrays

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Jan 9, 2018
@ayrton04
Copy link

ayrton04 commented Jan 9, 2018

Do we also need to update ParameterValue.msg, or is it only meant do be defining primitive values?

https://github.com/ros2/rcl_interfaces/compare/master...ayrton04:param-arrays?expand=1

@mikaelarguedas
Copy link
Member Author

Do we also need to update ParameterValue.msg, or is it only meant do be defining primitive values?

Absolutely 👍 updated accordingly

Copy link

@ayrton04 ayrton04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (or, at least, it matches what I have locally).

@mikaelarguedas
Copy link
Member Author

@ayrton04 I split and merged the renaming of the existing parameter array. I'll leave this one open and we will merge it along the corresponding rclcpp PR you're working on

@ayrton04
Copy link

Awesome! I’m blocked at the moment because of this:

#31

@mikaelarguedas
Copy link
Member Author

mikaelarguedas commented Jan 27, 2018

Ack, that's indeed a problem that need to be solved.
Though we do recommend people making contributions to develop and test their features in a workspace tracking master and built from source as ardent code and API will be out of sync pretty quick.
If it helps there's you can setup an environment development using this Dockerfile (to track master you will need to replace release-latest with master here)

@ayrton04
Copy link

Noted. Thanks for the heads-up, and for the fix!

@mikaelarguedas mikaelarguedas removed the in progress Actively being worked on (Kanban column) label Feb 1, 2018
@ayrton04
Copy link

Just a status update: I believe I'm all done with the rclcpp implementation, and am adding tests for ParameterVariant.

@mikaelarguedas mikaelarguedas added this to the bouncy milestone Mar 1, 2018
@mikaelarguedas mikaelarguedas added the in review Waiting for review (Kanban column) label Mar 15, 2018
@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Mar 21, 2018
@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 10, 2018
@mikaelarguedas mikaelarguedas merged commit 8e826d4 into master May 10, 2018
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label May 10, 2018
@mikaelarguedas mikaelarguedas deleted the paremeter_type_array branch May 10, 2018 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants