New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add array parameter types as defined in https://github.com/ros2/design/pull/152 #32
Conversation
Do we also need to update https://github.com/ros2/rcl_interfaces/compare/master...ayrton04:param-arrays?expand=1 |
6c8c265
to
eccba88
Compare
Absolutely 👍 updated accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (or, at least, it matches what I have locally).
eccba88
to
3b58e35
Compare
@ayrton04 I split and merged the renaming of the existing parameter array. I'll leave this one open and we will merge it along the corresponding |
Awesome! I’m blocked at the moment because of this: |
Ack, that's indeed a problem that need to be solved. |
Noted. Thanks for the heads-up, and for the fix! |
Just a status update: I believe I'm all done with the rclcpp implementation, and am adding tests for |
3b58e35
to
0ece21c
Compare
0ece21c
to
c0c4c5b
Compare
This is to support @ayrton04's work on implementing parameter arrays