Add action_msgs package #41
Conversation
Contains common message and service definitions for all ROS actions. Messages: - GoalStatus.msg - Contains a goal ID, timestamp, and status. - GoalStatusArray.msg - An array of GoalStatus.msg. - UUID.msg - Type of goal IDs; this is temporary until we port the existing uuid_msgs (see TODOs). Service: - CancelGoal.srv - API for canceling goals describing the cancel policy.
action_msgs/package.xml
Outdated
|
|
||
| <build_depend>builtin_interfaces</build_depend> | ||
|
|
||
| <exec_depend>builtin_interfaces</exec_depend> |
There was a problem hiding this comment.
I think <depend>builtin_interfaces</depend> to get all three build_depend, exec_depend, and build_export_depend would make sense because a C generator would export a header with an include to builtin_interfaces/msg/Time.h
There was a problem hiding this comment.
In general there are only two types of dependencies: the ones for build time and the ones for run time. Internally exec_depend and build_export_depend do the same thing - they are only named separately since users found it "easier" / more intuitive than run_depend.
Anyway if you use both then using depend makes sense 👍
jacobperron
added
in review
|
Ready for review. I've added GoalInfo.msg for encapsulating the goal ID and timestamp and updated the package.xml to use a CI:
|
|
Blocked by ros2/rosidl#307 |
|
| @@ -0,0 +1,6 @@ | |||
| # Goal ID | |||
| # TODO(jacobperron): Use a ported version of https://github.com/ros-geographic-info/unique_identifier/blob/master/uuid_msgs | |||
There was a problem hiding this comment.
Given that uuid_msgs has just a single message, I think the UUID.msg could live in builtin_interfaces rather than porting a package named uuid_msgs. Porting the tools in unique_id wouldn't need to block that.
Sounds good. |
|
|
|
@sloretz @dirk-thomas |
Contains common message and service definitions for all ROS actions.
Messages:
Service:
Resolves #40