Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change UUID type in action_msgs #54

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Change UUID type in action_msgs #54

merged 2 commits into from
Dec 4, 2018

Conversation

apojomovsky
Copy link
Contributor

@apojomovsky apojomovsky commented Nov 21, 2018 •
edited
Loading

This PR is part of a series of three that together close #49
EDIT: Depends on ros2/ros2#609

  • Replace the uint8[16] field from GoalInfo.msg with unique_identifier_msgs/uuid
  • Add the required cmake bits

@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Nov 21, 2018
jacobperron
jacobperron approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending green CI

@apojomovsky
Copy link
Contributor Author

apojomovsky commented Nov 21, 2018 •
edited
Loading

Linux CI: Build Status

@apojomovsky apojomovsky force-pushed the apojomovsky/change_uuid_type_in_action_msgs branch from cacc2c8 to c84b7cd Compare November 21, 2018 17:27
@sloretz sloretz mentioned this pull request Nov 27, 2018
Closed
24 tasks
@apojomovsky apojomovsky mentioned this pull request Dec 4, 2018
Merged
sloretz
sloretz approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI if the IDL PRs don't get merged in time. Actually this one doesn't depend on the IDL prs, oops.

@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 4, 2018
@sloretz
Copy link
Contributor

sloretz commented Dec 4, 2018

CI with this and ros2/rcl#338 (not including ros2/rosidl#332 since that should be merged after ongoing IDL work)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit ed5a129 into ros2:master Dec 4, 2018
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Dec 4, 2018
dirk-thomas pushed a commit to ros2/test_interface_files that referenced this pull request Jan 18, 2019
@sloretz
Change UUID type in action_msgs (ros2/rcl_interfaces#54)
39cf4c4 
* Change UUID type in action_msgs

* Added unique_identifier_msgs dependency to action_msgs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@sloretz sloretz sloretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change UUID type in action_msgs
5 participants
@apojomovsky @sloretz @jacobperron @tfoote @dirk-thomas